Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VecAllocation should have an impl Drop #10

Closed
glandium opened this issue Apr 24, 2019 · 1 comment
Closed

VecAllocation should have an impl Drop #10

glandium opened this issue Apr 24, 2019 · 1 comment

Comments

@glandium
Copy link

Like BoxAllocation, VecAllocaton should have an impl Drop that removes the element that was added if no initialization happened.
@kvark
Copy link
Owner

kvark commented Apr 24, 2019

No, VecAllocation doesn't need a drop. There is no element added that should be removed: all that's been done by that point is reservation change to the vector, which is fine to leave.

@kvark kvark closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @glandium