New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New enforcement of String
over LargeBinary
on EncryptedType breaks existing implementations
#444
Comments
Continuing the conversation from #426 (comment):
|
The change introduced by #426 breaks alembic migration code that works on MySQL on import sqlalchemy as sa
from alembic import op
from sqlalchemy_utils import EncryptedType
...
def upgrade():
op.add_column(
"dbs", sa.Column("password", EncryptedType(sa.String(1024)), nullable=True)
)
|
Ditto this for me: this is a breaking change that would require a semver update and doc on what to do instead. I get the following stacktrace on a migration that works fine with 0.36.4 on MariaDB versions 10.3.x and 10.4.x:
The column that triggers this error is defined thus:
Please revert the change, fix it in a way that doesn't break this straightforward case, or provide doc on what I need to change this to. |
I agree with @instantlinux , this really should be reverted in |
Here to iterate the same thing as @instantlinux, this has broken our existing migrations and it would be great to have some updating notes before adding such a change. @villebro Have you had any luck fixing the migration problems for MySQL? |
Hello, I was surprised by this change but I appreciate this was quickly addressed. However, 0.36.6 is still broken compared to 0.36.4 on my code base when using (PostgreSQL 11). Reverting to 0.36.4 works fine. So the question is, should I pin to 0.36.4 for now or was 0.36.6 meant to work? Thanks :) |
See my comment on #426, which is when this was introduced.
The text was updated successfully, but these errors were encountered: