Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #426 and add support for Legacy Encrypted Type #450

Merged
merged 5 commits into from May 24, 2020

Conversation

rushilsrivastava
Copy link
Contributor

@rushilsrivastava rushilsrivastava commented May 23, 2020

This PR attempts to solve the problems outlined in #444 which were introduced in #426. The idea is to keep the old LargeBinary implementation and add a deprecated warning to it, as well as add support for the new String implementation for EncryptedType.

@rushilsrivastava
Copy link
Contributor Author

Currently using @leosussan's code from this comment.

@rushilsrivastava
Copy link
Contributor Author

EncryptedType now works for my local migrations. Should throw a warning when using it as well? Can't confirm this works.

@rushilsrivastava rushilsrivastava changed the title WIP: Revert #426 and add support for Legacy Encrypted Type Revert #426 and add support for Legacy Encrypted Type May 23, 2020
@rushilsrivastava
Copy link
Contributor Author

CC @kvesteri, it looks like the linter is having problems with code that hasn't been modified.

@kvesteri kvesteri merged commit 710bd89 into kvesteri:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants