-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add support for JSONB #125
Conversation
MSusik
commented
Feb 6, 2015
- Replaces default JSONType implementation with JSONB.
* Replaces default JSONType implementation with JSONB.
Is there a way to parametrize tests? I'd like to have tests inside |
Hi guys, any reason this is not getting merged? |
0d964f3
to
204aba3
Compare
3604f2b
to
e6ec12a
Compare
👍 on merging, could really use this! |
I'm struggling to find a way how to use JSON and JSONB comparators with this type (http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html?highlight=jsonb#sqlalchemy.dialects.postgresql.JSONB). If we can't find a way I'd be inclined to remove the PostgreSQL dialect implementation and just stick with Unicode for all dialects. Without the comparators we lose much of the power of JSON and JSONB. Is there a reason why you want to use JSONType over native JSONB type? I'm currently just using JSONB on all my projects (on the other hand I'm using PostgreSQL on every project). |
The case that made me write this simple PR was that the software I was developing was supposed to work with different versions of Postgre. |
51522a0
to
bed7672
Compare
7903e2e
to
05fc174
Compare
SQLAlchemy will have native JSON type as of 1.1. I'll deprecate and remove JSONType from SA-Utils at some point. |