Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add support for JSONB #125

Closed
wants to merge 1 commit into from
Closed

WIP Add support for JSONB #125

wants to merge 1 commit into from

Conversation

MSusik
Copy link

@MSusik MSusik commented Feb 6, 2015

  • Replaces default JSONType implementation with JSONB.

* Replaces default JSONType implementation with JSONB.
@MSusik
Copy link
Author

MSusik commented Feb 6, 2015

Is there a way to parametrize tests?

I'd like to have tests inside JSONTestCase run twice, for both values of binary in JSONType constructor.

@MSusik MSusik mentioned this pull request Feb 6, 2015
@lsbardel
Copy link

lsbardel commented Jun 9, 2015

Hi guys, any reason this is not getting merged?

@adamhadani
Copy link

👍 on merging, could really use this!

@kvesteri
Copy link
Owner

I'm struggling to find a way how to use JSON and JSONB comparators with this type (http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html?highlight=jsonb#sqlalchemy.dialects.postgresql.JSONB). If we can't find a way I'd be inclined to remove the PostgreSQL dialect implementation and just stick with Unicode for all dialects. Without the comparators we lose much of the power of JSON and JSONB.

Is there a reason why you want to use JSONType over native JSONB type? I'm currently just using JSONB on all my projects (on the other hand I'm using PostgreSQL on every project).

@MSusik
Copy link
Author

MSusik commented Oct 28, 2015

Is there a reason why you want to use JSONType over native JSONB type? I'm currently just using JSONB on all my projects (on the other hand I'm using PostgreSQL on every project).

The case that made me write this simple PR was that the software I was developing was supposed to work with different versions of Postgre.

@kvesteri
Copy link
Owner

SQLAlchemy will have native JSON type as of 1.1. I'll deprecate and remove JSONType from SA-Utils at some point.

@kvesteri kvesteri closed this Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants