Added SQLite support for PasswordType #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue of column type mismatch on SQLite as
VARBINARY
type fallbacks toNUMERIC
, and in the end, Alembic always detects changes in my project:According to this reply on SQLAlchemy support forum,
sa.VARBINARY
is not a good fallback, but I have no idea on how would a correct implementation look like, so I only added SQLite support.Originally, I thought my problem is reported in #106, but it turned out to be another not quite closely related issue.
#233 is another enhancement for PasswordType, which, in fact, solves #106.