This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Phishing address warning #1674
Merged
Phishing address warning #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gamalielhere
commented
Mar 13, 2018
gamalielhere
commented
- Compile list of phishing addresses from @kvhnuke and etherscamdb.info
- Rewrite html render with string literal (tested in safari too)
- Compare user input to any phishing addresses and display warning text
kvhnuke
approved these changes
Mar 13, 2018
kvhnuke
reviewed
Mar 13, 2018
| var checkDarkList = function(value) { | ||
| for(let i = 0; i < Darklist.length; i++) { | ||
| if(value.length > 0 && value === Darklist[i].address) { | ||
| scope.phishing.msg = Darklist[i].comment !== '' ? `This address has been flagged: ${Darklist[i].comment}` : 'This address has been flagged in our Phishing list. Please make sure you are sending to the right address'; |
There was a problem hiding this comment.
we have to add this line to translation files
kvhnuke
reviewed
Mar 13, 2018
| @@ -74,6 +74,11 @@ globalFuncs.errorMsgs = [ | |||
| 'Bid must be more than the specified minimum' // 39 | |||
| ]; | |||
|
|
|||
| globalFuncs.phishingWarning = [ | |||
There was a problem hiding this comment.
you also have to add this to https://github.com/kvhnuke/etherwallet/blob/mercury/app/scripts/controllers/tabsCtrl.js#L261 thats where it gets the translated version and replace it with object's value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.