Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor: StrawberryPerl 5.20.2.1 broken and approved. causes mayhem in our lovely bug free project. #1773

Closed
un1versal opened this issue Dec 15, 2015 · 15 comments

Comments

@un1versal
Copy link
Contributor

This ticket is here only in order to track progress on package version chocolatey side,

I wonder why this was so sudden as its been working until now. but blame lies with StrawberryPerl 5.20.2.1 packages.

workaround merged in master by Dessa in 4640e16

c:\cygwin\bin\bash : /usr/bin/bash: /cygdrive/c/Strawberry/perl/lib/core/config.h: No such file or directory
At line:6 char:5
+     c:\cygwin\bin\bash -c "/bin/cat .appveyor.perl >> /cygdrive/c/Strawberry/per ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (/usr/bin/bash: ...le or directory:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

c:\cygwin\bin\touch : /usr/bin/touch: cannot touch '/cygdrive/c/Strawberry/kvirc_workaround': No such file or directory
At line:7 char:5
+     c:\cygwin\bin\touch /cygdrive/c/Strawberry/kvirc_workaround
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (/usr/bin/touch:...le or directory:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Command executed with exception: /usr/bin/touch: cannot touch '/cygdrive/c/Strawberry/kvirc_workaround': No such file or directory

KVIrc/.appveyor.yml

Lines 69 to 71 in fbe86a9

# Strawberry perl doesn't support MSVC, but we force the support.
c:\cygwin\bin\bash -c "/bin/cat .appveyor.perl >> /cygdrive/c/Strawberry/perl/lib/core/config.h"
c:\cygwin\bin\touch /cygdrive/c/Strawberry/kvirc_workaround

No windows builds :(

@DarthGandalf
Copy link
Member

Cygwin builds? o_O
KVIrc doesn't really build in Cygwin...
Just some tools of it are used instead of PowerShell tools.

2015-12-15 15:47 GMT+00:00 un1versal notifications@github.com:

c:\cygwin\bin\bash : /usr/bin/bash: /cygdrive/c/Strawberry/perl/lib/core/config.h: No such file or directory
At line:6 char:5

  • c:\cygwin\bin\bash -c "/bin/cat .appveyor.perl >> /cygdrive/c/Strawberry/per ...
    
  • - CategoryInfo          : NotSpecified: (/usr/bin/bash: ...le or directory:String) [], RemoteException
    - FullyQualifiedErrorId : NativeCommandError
    
    

c:\cygwin\bin\touch : /usr/bin/touch: cannot touch '/cygdrive/c/Strawberry/kvirc_workaround': No such file or directory
At line:7 char:5

  • c:\cygwin\bin\touch /cygdrive/c/Strawberry/kvirc_workaround
    
  • ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    • CategoryInfo : NotSpecified: (/usr/bin/touch:...le or directory:String) [], RemoteException
    • FullyQualifiedErrorId : NativeCommandError

Command executed with exception: /usr/bin/touch: cannot touch '/cygdrive/c/Strawberry/kvirc_workaround': No such file or directory

No windows builds :(


Reply to this email directly or view it on GitHub
#1773.

@un1versal
Copy link
Contributor Author

https://chocolatey.org/packages/StrawberryPerl thx Dessa.

We look with some sad frown and wonkey eyed at @gep13 for accepting a knowing broken package and hope @alanstevens and https://chocolatey.org/profiles/railmeat to update strawberry perl packages in chocolatey to a non broken version :D

@Dessa fixed it by forcing a non broken version in 4640e16, but that's just not ideal.

@un1versal un1versal changed the title Appveyor: cygwin builds failing. Appveyor: StrawberryPerl 5.20.2.1 broken and approved. causes mayhem in our lovely bug free project. Dec 15, 2015
@DarthGandalf
Copy link
Member

Why do you think it's "knowing broken package"?

2015-12-15 17:02 GMT+00:00 un1versal notifications@github.com:

We look with some sad frown and wonkey eyed at @gep13
https://github.com/gep13 for accepting a knowing broken package and
hope @alanstevens https://github.com/alanstevens and
https://chocolatey.org/profiles/railmeat to update strawberry perl
packages in chocolatey to a non broken version :D


Reply to this email directly or view it on GitHub
#1773 (comment).

@un1versal
Copy link
Contributor Author

read the comments in https://chocolatey.org/packages/StrawberryPerl and Dessa said so in IRC.

@un1versal
Copy link
Contributor Author

See alanstevens/ChocoPackages#72 if anything happens there Ill update here in order to try an track progress on this.

@gep13
Copy link

gep13 commented Dec 15, 2015

@un1versal please accept my apologies. That package version should not have been approved. I have removed the listed version from Chocolatey.org, and it will no longer be installed by default. Instead, you will get the previous version, which was working for you.

Should the package be updated, based on your issue that you opened, the new package version will again be added to chocolatey.org, assuming it is proven to work correctly.

Apologies again.

@un1versal
Copy link
Contributor Author

@gep13 welcome and thank you for quick reply ;) things like this are bound to happen. 😉 I sure hope it wasn't coming off too harsh. Sense of humour is a bit funky also... So excuse the oddities. 😁

Im not sure how chocolatey,org works exactly but Ive opened a PR to test the next version out and see if that's working better. See alanstevens/ChocoPackages#73, if you have any suggestion how to best proceed the advice and insight will surely be welcome.

Thanks for removing that broken package, Im sure more people will sleep easier tonight knowing that. :

Regards and thanks again.

@un1versal
Copy link
Contributor Author

fixed upstream closing here...

@gep13
Copy link

gep13 commented Dec 16, 2015

In all honesty, I am not sure when, if at all, that PR will get accepted 😢 Alan has sort of stepped away from maintaining his packages due to other committments, so unless the other maintainer picks up this request, it might go unanswered. Since we rely on community contributions, if this application is one that you use a lot, we would welcome any contributions that you could make. For instance, I could add you as a maintainer for the application.

In terms of keeping things working as part of your CI, it probably makes sense to take a fixed version, that you know works, rather than automatically installing every new version. Only do that once you have tested the application elsewhere and you know it works.

@un1versal
Copy link
Contributor Author

Ideally we would test a version before it gets accepted as a replacement in chocolatey but we/I cant do that until its already in there (either as a beta or something) that would be a semi-sane and easy way to go without disturbing anything too much and maybe it would benefit others as well...

If thats possible I wont mind giving it a wirl and see how that goes. The other team members are quite happy with the version that works but to me personally given the info about the current maintainer that version will soon get old quick. So Ill make a small effort there.

@un1versal
Copy link
Contributor Author

maybe its better if I push that pacjage to an active maintainer who already has an account setup and chocolatey stuff setup.

@gep13
Copy link

gep13 commented Dec 16, 2015

@un1versal that "might" work, but the ideal would be for you to take ownership of the package. Getting an account set up on Chocolatey is very simple, and I can get you added as a maintainer. @ferventcoder already has a LOT of packages, and I don't think he will be in a position to take on more. His main focus, like mine, is to add features/fix bugs within Chocolatey itself. A better option if you are not in a position to maintain, would be to reach out to @dtgm who "might" be able to help out.

@un1versal
Copy link
Contributor Author

well lest see what he says, Ive put my name on package and made a PR ferventcoder/chocolatey-packages#104. if he declines as is his right, then open an account and we try that... Is that OK?

Is it possible btw to put package in pre-release so we can force that version on our CI and test it out before you give it final blessing?

btw thanks for help so far ;)

@gep13
Copy link

gep13 commented Dec 16, 2015

@un1versal said...
Is it possible btw to put package in pre-release so we can force that version on our CI and test it out before you give it final blessing?

Again, the ideal would be that the package is tested somewhere else, before pushing to Chocolatey.org. For instance, you can push package to a MyGet.org feed, test them as part of your CI process, and once you are happy that they work, you can push them to Chocolatey.org.

@un1versal
Copy link
Contributor Author

Thats what I thought, sadly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants