Port the mediaplayer mpris interface to mpris 2.2; fix #1912 #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mediaplayer module's MPRIS interface from version 1 to version 2.2 (https://specifications.freedesktop.org/mpris-spec/latest/)
Version 1 of the specification is considered obsolete and broken; all media players already updated to the new spec years ago.
Two dead mediaplayers got removed (Mozilla Songbird and BMPx).
This PR has been tested working with VLC, Clementine and Audacity.
A flaw has been found in the position/length handling: the variable holding the milliseconds value is an int, so it will report broken values for long files; from my tests it breaks after around 15 minutes. The fix is not contained in this PR since it requires a data type change in all the other interfaces, too.