Replace QtWebKit with QtWebEngine; fix #1854 #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is needed for Qt6 (qtwebkit doesn't exists anymore). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three items are affected by this change:
It can also work without it, falling back to QTextBrowser
It has been ported, and it's just as broken as it was before (the links on the website points to not-existing ftp.kvirc.de, uninstall never worked)
It has been ported, but all the functions used to manipulate elements on the DOM have been removed since QtWebEngine doesn't include them. Everything must be ported to use plain javascript.
Dropping QtWebkit is past due, since you don't want to browse the web with a 2016 browser.
QtWebEngine is still "old" on Qt5, and probably KVIrc would be better compiled with WANT_WEBKIT=no anyway.