Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strnatcasecmp returns incorrect values #268

Closed
elynnaie opened this issue Dec 21, 2015 · 3 comments
Closed

strnatcasecmp returns incorrect values #268

elynnaie opened this issue Dec 21, 2015 · 3 comments
Assignees
@kukawski

Comments

@elynnaie
Copy link

strnatcasecmp('0A', '5N') incorrectly returns 1. PHP 5.6.16 and PHP 7 correctly return -1.
@kukawski kukawski self-assigned this Feb 1, 2016
@kvz kvz added the confirmed label May 21, 2016
kukawski added a commit that referenced this issue Jun 4, 2016
@kukawski
Reimplemented strnatcmp and strnatcasecmp to follow PHP more strictly
8ad852f 
Fixes issue #268
Added _php_cast_string helper to have one place for type conversion
that follows PHP's logic
@kukawski
Copy link
Collaborator

kukawski commented Jun 5, 2016

This issue is fixed now.

@kukawski kukawski closed this as completed Jun 5, 2016
@seanthebean
Copy link

Thanks so much @kukawski ! Would you mind also posting here when the fix is released?

@kvz
Copy link
Collaborator

kvz commented Jun 16, 2016

Hey there, I just pushed out v2.0.5 which contains this work.

@andrecsmenezes andrecsmenezes mentioned this issue Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kukawski kukawski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kvz @elynnaie @kukawski @seanthebean