Skip to content

Commit

Permalink
MASSIVE changes to the code but this is because I'd not had git runni…
Browse files Browse the repository at this point in the history
…ng properly for a couple of weeks so regular small commits didn't happen as usual >.<

Added a 'modaCheckpoint' function that can be called and will temporarily halt script execution while giving an indication of where in the script is currently being executed - useful to hunt down which part of a script is freezing for example (find last place alert was called and bug will be just after this..)

Altered code style throughout to have a space following a comma;

Starting to migrate to the new userPreference() interface;

Added a bunch of translation strings;

Source of freezing on the initial setup appears to be when setting the numberOfRentedReferrals - when the setPref('numberOfRentedReferrals', tmp_rentedRefs[1], { prefType: 'integer' }); part line is replaced by a 0 the script setup does not freeze;

throw if setup isn't complete rather than return (return causes issues when being run within the firebug console as it isn't within a function block - greasemonkey automatically wraps scripts within an anonymous function);

added checks to the referral listings functions so that they do not cause issues if the item is not supplied / is null -- eg, on the direct referral listings page the flagIdToColour does not have a flagId to convert thus breaks, similarly for ultimateClickValues;

 improved direct referral listings page functionality so that (hopefully) it isn't as broken / it actually works somewhat (eg only try to textify the flag if it is the rented referral listings page / column indexes are distinct for each listings page);

 Removed alert()s when pages break - TODO stop catching errors and just let the script fail;
  • Loading branch information
kwah committed Jun 21, 2011
1 parent dabebc4 commit a4a533c
Showing 1 changed file with 543 additions and 281 deletions.

0 comments on commit a4a533c

Please sign in to comment.