Re-export top-level imports to satisfy Mypy #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Mypy (at least in strict mode) with the library as it currently is causes errors.
It seems to be good practice to 're-export' (using
__all__
) all the things that you import into a module and wish to allow others to use as an import. I don't think this is actually functionally different, but just a convention.IDEs (auto-import feature) and Mypy pick up on this, at the very least.
Signed-off-by: Olivier Wilkinson (reivilibre) oliverw@matrix.org
I am happy for these changes to be available under the project's licence (MIT).