Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS not rendering #53

Closed
rudijs opened this issue Jun 20, 2015 · 21 comments
Closed

CSS not rendering #53

rudijs opened this issue Jun 20, 2015 · 21 comments
Labels
bug

Comments

@rudijs
Copy link

rudijs commented Jun 20, 2015

Hi,

Not sure why, maybe it's just me, but all of a sudden the css is not rendering at all?

Everything appears to be OK, ie css scripts load, but nothing seems to be computed.

Here's a screencap from Chromium (same on Chrome and FireFox for me here).

Anyone else seen this behavior?

selection_004
@sprijk
Copy link

sprijk commented Jun 20, 2015

+1

Same here!

@kwk
Copy link
Owner

kwk commented Jun 20, 2015

@rudijs @sprijk thank you for reporting your issue. Please let me know which version you're running. See bottom of the page for the corresponding git revision. Do you remember which git revision worked for you? That would help a lot.

@so0k
Copy link

so0k commented Jun 21, 2015

it happens on both konradkleine/docker-registry-frontend:latest & konradkleine/docker-registry-frontend:v1 in my case. I did have a registry:2 container it linked to, and no v1, but not sure if that's related to this issue.

@rudijs
Copy link
Author

rudijs commented Jun 21, 2015

@kwk I'm git revision: ff69f40

Sorry I don't have the previously working revision, I'm currently only using this on a vagrant VM and I've destroyed the earlier one.

@far-blue
Copy link

I'm getting this as well. Git revision ff69f40. Running Safari Version 8.0.6 (10600.6.3) (OS X 10.10.3). I'm seeing this on the console: "Unexpected CSS token: :". It says the issue is on line 1 but, of course, the css is compressed so there is only one line.

@kuvi-innovations
Copy link

+1

Same here

@kwk kwk added the bug label Jun 23, 2015
@kwk
Copy link
Owner

kwk commented Jun 23, 2015

I'm working on it...

@acaranta
Copy link

+1 sry I bothered you on twitter for an already declared issue ;)

@kwk
Copy link
Owner

kwk commented Jun 23, 2015

@rudijs can you confirm that none of the default bootstrap CSS is loading? I think only the toastr and our custom CSS is loaded but not the bootstrap CSS. A quick build of older revisions shows me the same issue here. Therfore I assume some of the external dependencies like Grunt / Bower / NPM have changed in some way. I'm looking into the build output.

@rudijs
Copy link
Author

rudijs commented Jun 23, 2015

@kwk Here's a screen cap from Chromium just now.

The red arrow points to the styles, where nothing seems to be computed.

This suggests Bootstrap is not bootstrapping?

I'm not a bootstrap user (Foundation or Material Design mostly), so I'm not sure where to look exactly other than the dev tools tab.

If you have other suggestions where to look just let me know and I'll have a dig.

selection_003

@rudijs
Copy link
Author

rudijs commented Jun 23, 2015

@kwk Here's a shot of inspecting the 'Repositories' text element

selection_004

@rudijs
Copy link
Author

rudijs commented Jun 23, 2015

@kwk CSS is getting http 200 status OK

selection_005

@bpholt bpholt mentioned this issue Jun 24, 2015
Open
@kwk
Copy link
Owner

kwk commented Jun 25, 2015

It looks like the grunt build step is kicking bootstrap's CSS out. Maybe it thinks it is unused or it cannot find a proper CDN for it. I don't know yet but I'm on it. This behavior is new.

@kwk kwk closed this as completed in cb3c650 Jun 25, 2015
@kwk
Copy link
Owner

kwk commented Jun 25, 2015

I've temporarily fixed the issue and a build should be available in the next hour on the docker hub. Please test the build and report that my change fixed the issue for you as well.

@kwk
Copy link
Owner

kwk commented Jun 25, 2015

Ready to use images are available now from the docker hub. Please pull and re-run your containers and let me know what you find out.

@sprijk
Copy link

sprijk commented Jun 25, 2015

Works, thanks!
Op 25 jun. 2015 13:46 schreef "Konrad Kleine" notifications@github.com:

Ready to use images are available now from the docker hub. Please pull and
re-run your containers and let me know what you find out.

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

@rudijs
Copy link
Author

rudijs commented Jun 25, 2015

@kwk Thanks Konrad!

@far-blue
Copy link

LGTM

@kwk
Copy link
Owner

kwk commented Jun 25, 2015

Thank you @rudijs @sprijk @far-blue @acaranta @so0k @kuvi-innovations for reporting this bug and for testing it for me!

@acaranta
Copy link

Thx for working on it ;)

goern pushed a commit to goern/docker-registry-frontend that referenced this issue Aug 30, 2015
@kwk @goern
Attempt to fix kwk#53
cc529b5 
Somehow grunt-wiredep kicks out bootstrap from the app/index.html file.
This is not nice and we need to find a better way than to simply commen
it out in the build step but for now it fixes the issue of missing
Bootstrap CSS.
kwk added a commit that referenced this issue Sep 3, 2015
@kwk
Fix #53 by going to bootstrap 3.3.4
9e07142
kwk added a commit that referenced this issue Sep 16, 2015
@kwk
Revert "Attempt to fix #53"
ccc0ded 
This reverts commit cb3c650.
@mvdkleijn
Copy link

This does not appear to be fixed and docker pull says I'm on the latest version...

publicitas-deployment pushed a commit to publicitas-deployment/docker-registry-frontend that referenced this issue Oct 6, 2016
Merge remote-tracking branch 'origin/master' into v2
a1c285c 
* origin/master:
  Add imagelayers.io label
  Revert "Attempt to fix kwk#53"
  Simplified develop instructions
  Update README.md
  Fix problem with SSL CA when setting up development containers

# Conflicts:
#	develop/Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kwk @far-blue @mvdkleijn @acaranta @rudijs @so0k @sprijk @kuvi-innovations