馃悰Fix tag links navigating to home #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the test links when clicked would take you to the default page (in this case the repositories view). This only happened on images which didn't have a user prefix (i.e. nginx vs. my/nginx). This happened because the links were built expecting the prefix so the URL was //nginx but that was not routed properly so the user fell into the catch other 'otherwise' handler which took them to the repositories view. This change set fixes that by building the links with URLs that include the prefix if it exists or without the prefix if the image does not have a user prefix.
|
Maybe that is an other issue, but in the docker image reference definition tests there is an example for multiple subrepo path component names: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tag links when clicked would take you to the default page (i.e. home view).
This only happened on images which didn't have
a user prefix (i.e.
nginxvs.my/nginx).This happened because the links were built expecting the prefix so the URL
was
//nginxbut that was not routed properly so the user fell into the catchother otherwise handler which took them to the repositories view.
This change set fixes that by building the links with URLs that include the
prefix if it exists or without the prefix if the image does not have a user
prefix.