This repository has been archived by the owner on Feb 27, 2020. It is now read-only.
refactor(loaddictionary): only accept arraybuffer #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: loadDictionary does not read physical file from path anymore
This PR changes interface to
loadDictionary
to accept arrayBuffer only. Previously it also accepts physical path to dic / aff and read it, mount into wasm's memory space. For the preparation of electron's new async spellchecker, it is expected to create instance of provider in any context like worker, or renderer, vice versa - and detecting & supporting various env to load dictionary is non trivial job.Any env should able to create arraybuffer from file contents instead - in main process
fs
can read file into buffer, and any other renderer processfetch
or similar allows to retrieve contents from remote endpoint. Spellchecker provider now expects per-context handling occurs in caller's side.