Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(createmoduleloader): fix non treeshakable import #172

Merged
merged 3 commits into from
Jan 26, 2019
Merged

Conversation

kwonoj
Copy link
Owner

@kwonoj kwonoj commented Jan 26, 2019

No description provided.

@kwonoj kwonoj merged commit 751ac55 into master Jan 26, 2019
@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #172 into master will decrease coverage by 0.57%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage    96.2%   95.62%   -0.58%     
==========================================
  Files          12       12              
  Lines         158      160       +2     
  Branches       19       21       +2     
==========================================
+ Hits          152      153       +1     
  Misses          4        4              
- Partials        2        3       +1
Impacted Files Coverage Δ
src/loadAsmModule.ts 55.55% <ø> (ø) ⬆️
src/createModuleLoader.ts 86.66% <100%> (-3.34%) ⬇️
src/loadModule.ts 93.75% <88.88%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119ab73...c3d2d1e. Read the comment docs.

@kwonoj kwonoj deleted the fix-treeshake branch January 26, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant