Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loadmodule): deprecate locatebinary, back to single file #180

Merged
merged 7 commits into from
Jan 30, 2019

Conversation

kwonoj
Copy link
Owner

@kwonoj kwonoj commented Jan 30, 2019

After iterating few experiments, I realized it was somewhat tricky to create loader logic to satisfy all environment (node, electron's renderer + nodeintegration, browser) with disabling single_file. Still separate wasm binary with indexeddb cache is more preferred way, but will postpone until find better way to introduce resolve logic in loader.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #180 into master will decrease coverage by 0.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   99.27%   98.49%   -0.78%     
==========================================
  Files          10       10              
  Lines         138      133       -5     
  Branches       18       15       -3     
==========================================
- Hits          137      131       -6     
- Partials        1        2       +1
Impacted Files Coverage Δ
src/loadModule.ts 85.71% <100%> (-9.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c728c...c12979e. Read the comment docs.

@kwonoj kwonoj merged commit eaabb49 into master Jan 30, 2019
@kwonoj kwonoj deleted the feat-single-file branch January 30, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant