Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(loadmodule): refactor to use getmoduleloader #67

Merged
merged 12 commits into from
Sep 15, 2017

Conversation

kwonoj
Copy link
Owner

@kwonoj kwonoj commented Sep 15, 2017

This PR refactors out loadModule logic into separate module https://github.com/kwonoj/emscripten-wasm-loader and removes most of preprocessor scripts via kwonoj/docker-hunspell-wasm#28, but provides interfaces for customizable asm module object.

@codecov
Copy link

codecov bot commented Sep 15, 2017

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     10    -3     
  Lines         143    120   -23     
  Branches       21     14    -7     
=====================================
- Hits          143    120   -23
Impacted Files Coverage Δ
src/util/logger.ts 100% <100%> (ø) ⬆️
src/loadModule.ts 100% <100%> (ø) ⬆️
src/index.ts 100% <100%> (ø) ⬆️
src/hunspellLoader.ts 100% <100%> (ø) ⬆️
src/mountDirectory.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd996c...e74314e. Read the comment docs.

@kwonoj kwonoj merged commit 845ef23 into master Sep 15, 2017
@kwonoj kwonoj deleted the refactor-preprocessor branch September 15, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant