Deploy refinement #559
Merged
Deploy refinement #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## unstable #559 +/- ##
============================================
- Coverage 73.21% 72.96% -0.25%
============================================
Files 34 34
Lines 5155 5211 +56
============================================
+ Hits 3774 3802 +28
- Misses 1381 1409 +28
Continue to review full report at Codecov.
|
rodrigosiqueira
force-pushed
the
deploy-refinement2
branch
from
3ad2df1
to
8ebb97b
Compare
Currently, kw does not provide an easy mechanism to change where kw deploys the necessary scripts and the temporary folder, which can add unnecessary constraints to users. This commit introduces two new configuration variables that enable users to specify where they want to save kw files in the remote and which folder they want to use for temporary files during the deploy. Closes: kworkflow#470 Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
In the ArchLinux machine, kw leaves a lot of leftover files on the uninstall option. This commit fixes this issue and refactors the core function related to the kernel uninstall to make it simple and scalable. Closes: kworkflow#186 Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
When we run kw remote, we have to deal with a tiny interface that expects two parameters every time; as a result, in the deploy code, we repeat those standard parameters over and over again. This hurts the code readability and damages the idea of interface; this commit solves this problem by creating a standard prefix to interact with the remote interface. Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Add lzop as a default compression in the deploy process and also enable users to set their preferable compression algorithm. Closes kworkflow#188 Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
kw deploy generates a very polluted output, this commit cleanup the output by: * Hide unnecessary command log * Use progress bar for modules_install * Add messages per deploy milestone * Add --verbose in case user want to know every step Note: This is part of the issue kworkflow#179 Signed-off-by: Rodrigo Siqueira <siqueirajordao@riseup.net>
This commit is a simple code refactor that extracts the config copy from the host machine to the target machine to a single function. Signed-off-by: Rodrigo Siqueira <siqueirajordao@riseup.net>
We are expanding the set of distros supported by kw; as a result, the detect_distro was implemented in a way that is hard to expand the set of the supported distro. This commit adds an array per distro family to address this problem, where each element represents a specific derivative distro. Signed-off-by: Rodrigo Siqueira <siqueirajordao@riseup.net>
rodrigosiqueira
force-pushed
the
deploy-refinement2
branch
from
8ebb97b
to
be0b499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working to improve the overall quality of the deploy code; as a result, this PR is part of this effort. Here, you will see some simple code refactor that will make adding support for other distros and systems easier.