Allow some kw deploy commands to be run outside kernel tree
#768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.21% // Head: 73.21% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## unstable #768 +/- ##
============================================
- Coverage 73.21% 73.21% -0.01%
============================================
Files 41 41
Lines 6865 6872 +7
============================================
+ Hits 5026 5031 +5
- Misses 1839 1841 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Previously, there were individual printf redirects to the same file, which conflicted with rule SC2129 of ShellCheck that says to bundle those redirects in only one (https://www.shellcheck.net/wiki/SC2129). The reasoning is that the file is opened and closed only once and thus there is a performance gain, although, in this case, the gain is irrelevant being more an issue of keeping the project coding style. Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
Before this commit, there was an unreachable command that made the ShellCheck fail (https://www.shellcheck.net/wiki/SC2317). The fix was to simply move the command one line before the return command (which caused the unreachable command). Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
As per ShellCheck documentation (https://www.shellcheck.net/wiki/SC2317) some commands may be incorrectly considered unreachable. In this case, the fix was made disabling this rule for the accused command. Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
Some kw deploy commands, such as --list and --uninstall, should be able to be executed outside a kernel tree. The implementation revolves around these commands enabling a flag that does not trigger the checking of an existing kernel tree in the current directory (like the --from-package deploy command). Important to say that the test cases associated with this implementation only check if the flag has been set, because the checking of an existing kernel tree is done in the deploy_main() which does not make sense to test. Closes kworkflow#734 Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
davidbtadokoro
force-pushed
the
issue_734
branch
from
b572b95
to
bb6ac3c
Compare
|
Very nice change! Tested, and merged in the unstable branch. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed in #734, some
kw deploycommands like--listand--uninstallcan't be run outside a kernel tree when they should. This PR implements this.Also, this PR contains commits fixing issues related with ShellCheck failures that I came across when implementing the above. The issues where:
deploy.sh(SC2317))deploy.sh(SC2129)deploy_test.sh(SC2129)