Adding verbose mode. #789

aquilamacedo · 2023-03-08T02:02:55Z

This commit adds support for the verbose parameter within kw build. The verbose parameter gives details of the commands that are executed behind the scenes.

Note: This is part of the issue: #179

aquilamacedo · 2023-03-08T02:05:37Z

Hi @rodrigosiqueira.

I've started implementing the verbose parameter in kw build, do you have any recommendations for something I can change/add?

src/build.sh

aquilamacedo · 2023-03-16T20:20:09Z

Hi @rodrigosiqueira.

I dedicated the commits to another pull request. When you merge, I'll update that pull request to continue the verbose option.

aquilamacedo · 2023-03-20T18:41:04Z

Hi @rodrigosiqueira. :)

I started to add verbose mode in some parts of the build, but I'm still implementing it for other parameters.

rodrigosiqueira · 2023-03-21T13:39:09Z

Any update here?

aquilamacedo · 2023-03-21T22:40:04Z

Hi @rodrigosiqueira.

The --verbose option works for all build options except in the --info parameter. I wondered if it is worth implementing, as the only commands running in the build_info function are the commands created by get_kernel_release() and get_kernel_versions(). What do you think?

documentation/man/features/build.rst

documentation/man/features/env.rst

rodrigosiqueira · 2023-03-22T11:51:20Z

Hi @rodrigosiqueira.

The --verbose option works for all build options except in the --info parameter. I wondered if it is worth implementing, as the only commands running in the build_info function are the commands created by get_kernel_release() and get_kernel_versions(). What do you think?

I think it is worth it. Check get_kernel_* function, and you will see that we are forcing SILENT.

rodrigosiqueira · 2023-04-10T17:37:24Z

Hi @aquilamacedo , could you finish this PR?

aquilamacedo · 2023-04-11T18:38:04Z

Hi @aquilamacedo , could you finish this PR?

yes, I'm almost done updating _kw.

documentation/man/features/build.rst

src/build.sh

src/kw_env.sh

src/build.sh

rodrigosiqueira · 2023-04-18T23:40:20Z

src/build.sh

+      --verbose | -v)
+        options_values['VERBOSE']=1
+        shift


Add a simple unit test for this new parameter (same idea for all the commits in this PR).

rodrigosiqueira · 2023-04-18T23:42:16Z

documentation/man/features/build.rst

@@ -83,6 +84,9 @@ OPTIONS
  build process, including configuration files and script output. This option also
  considers whether or not the user is using kw env.

+-v, \--verbose:
+  Verbose mode allows the user to see the commands executed under the hood.


Let's use something more formal in the documentation. Something like this:

Verbose mode. Causes kw to print debugging messages about its progress. This is helpful in debugging issues.

(Same idea for all commits)

src/kw_env.sh

src/backup.sh

documentation/man/features/mail.rst

src/mail.sh

This commit adds support for the verbose parameter within `kw build`. The verbose parameter gives details of the commands that are executed behind the scenes. Note: This is part of the issue: kworkflow#179 Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>

This commit adds support for the verbose parameter within `kw env`. The verbose parameter gives details of the commands that are executed behind the scenes. Note: This is part of the issue: kworkflow#179 Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>

This commit adds support for the verbose parameter within `kw backup`. The verbose parameter gives details of the commands that are executed behind the scenes. Note: This is part of the issue: kworkflow#179 Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>

This commit adds support for the verbose parameter within `kw mail`. The verbose parameter gives details of the commands that are executed behind the scenes. Note: This is part of the issue: kworkflow#179 Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>

This commit adds support for the verbose parameter within `kw explore`. The verbose parameter gives details of the commands that are executed behind the scenes. Note: This is part of the issue: kworkflow#179 Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>

This commit adds support for the verbose parameter within `kw drm`. The verbose parameter gives details of the commands that are executed behind the scenes. Note: This is part of the issue: kworkflow#179 Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>

rodrigosiqueira · 2023-04-30T20:41:28Z

Merged! Thanks

rodrigosiqueira requested changes Mar 10, 2023

View reviewed changes

aquilamacedo force-pushed the verbose_mode branch 2 times, most recently from 120e7b4 to 499a491 Compare March 20, 2023 18:23

rodrigosiqueira requested changes Mar 22, 2023

View reviewed changes

documentation/man/features/build.rst Outdated Show resolved Hide resolved

documentation/man/features/env.rst Outdated Show resolved Hide resolved

aquilamacedo marked this pull request as ready for review March 23, 2023 21:27

aquilamacedo force-pushed the verbose_mode branch from f3d5b40 to bcb6de7 Compare April 11, 2023 22:04

magalilemes reviewed Apr 11, 2023

View reviewed changes

documentation/man/features/build.rst Outdated Show resolved Hide resolved

src/build.sh Outdated Show resolved Hide resolved

src/kw_env.sh Show resolved Hide resolved

aquilamacedo force-pushed the verbose_mode branch 4 times, most recently from d060439 to 89b302d Compare April 15, 2023 14:50

rodrigosiqueira requested changes Apr 18, 2023

View reviewed changes

aquilamacedo force-pushed the verbose_mode branch from 6be4e4f to 73bb407 Compare April 26, 2023 19:27

aquilamacedo added 3 commits April 27, 2023 19:09

aquilamacedo force-pushed the verbose_mode branch from 73bb407 to b42bb20 Compare April 27, 2023 22:09

aquilamacedo added 3 commits April 27, 2023 19:14

aquilamacedo force-pushed the verbose_mode branch from b42bb20 to feba95c Compare April 27, 2023 22:14

rodrigosiqueira closed this Apr 30, 2023

aquilamacedo changed the title ~~src: build: Adding verbose mode.~~ Adding verbose mode. Jun 8, 2023

aquilamacedo deleted the verbose_mode branch June 7, 2024 18:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding verbose mode. #789

Adding verbose mode. #789

aquilamacedo commented Mar 8, 2023

aquilamacedo commented Mar 8, 2023

aquilamacedo commented Mar 16, 2023

aquilamacedo commented Mar 20, 2023

rodrigosiqueira commented Mar 21, 2023

aquilamacedo commented Mar 21, 2023

rodrigosiqueira commented Mar 22, 2023

rodrigosiqueira commented Apr 10, 2023

aquilamacedo commented Apr 11, 2023

rodrigosiqueira Apr 18, 2023

rodrigosiqueira Apr 18, 2023

rodrigosiqueira commented Apr 30, 2023

Adding verbose mode. #789

Adding verbose mode. #789

Conversation

aquilamacedo commented Mar 8, 2023

aquilamacedo commented Mar 8, 2023

aquilamacedo commented Mar 16, 2023

aquilamacedo commented Mar 20, 2023

rodrigosiqueira commented Mar 21, 2023

aquilamacedo commented Mar 21, 2023

rodrigosiqueira commented Mar 22, 2023

rodrigosiqueira commented Apr 10, 2023

aquilamacedo commented Apr 11, 2023

rodrigosiqueira Apr 18, 2023

Choose a reason for hiding this comment

rodrigosiqueira Apr 18, 2023

Choose a reason for hiding this comment

rodrigosiqueira commented Apr 30, 2023