Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2] Durability Loss on Hammer and excavators? #13

Closed
Daihok41 opened this issue Sep 16, 2022 · 7 comments
Closed

[1.19.2] Durability Loss on Hammer and excavators? #13

Daihok41 opened this issue Sep 16, 2022 · 7 comments
Assignees

Comments

@Daihok41
Copy link

Is there any way to make it so the durability loss on hammers and excavators use 1 durability per block mined or dug up? I noticed it only uses 2 durability even when 9 blocks are mined or dug.

@kwpugh kwpugh self-assigned this Sep 16, 2022
@kwpugh kwpugh changed the title Durability Loss on Hammer and excavators? [1.19.2] Durability Loss on Hammer and excavators? Sep 16, 2022
@kwpugh
Copy link
Owner

kwpugh commented Sep 16, 2022

I tried as well and it does two durability. Very odd. I do not actually explicitly code damage. The hammer simple extends the vanilla pickaxe and takes the damage when a block is broken. the surrounding blocks are tested/broken after the target block is broken. I will take a look at why two occur.

@kwpugh
Copy link
Owner

kwpugh commented Sep 16, 2022

Looking through the code, I see what I did wrong. It had to do with the return statement of the canMine() method. I will push and update today. It was the same issue on the excavators.

@kwpugh
Copy link
Owner

kwpugh commented Sep 16, 2022

Fixed in update.

@kwpugh kwpugh closed this as completed Sep 16, 2022
@Daihok41
Copy link
Author

Just tryed the update is there no way to make it so that it actually uses durability for each block mined or dug? Cause now they only use 1 durability even though you mine 9 blocks? just seems cheaty. I am not sure if you know what i mean .

@kwpugh
Copy link
Owner

kwpugh commented Sep 16, 2022

I understand what you mean. I have always had my area breaking tools only take one durability. Recently, in the fabric versions of the mod I added a config option for take durability based upon number of blocks broken. I may add that to the forge versions at some point.

I never agreed with the idea of taking 9 durability because it broke 9 blocks, I think it would take one durability because a hammer is a much larger tool than a pickaxe. However, I understand some folks can't get past that idea.

@kwpugh
Copy link
Owner

kwpugh commented Sep 16, 2022

v1.4.11 will have a config option for hammer and excavator to take full damage

@Daihok41
Copy link
Author

Huge thanks man I really appreciate the new update and I do love the mod by the way makes things simple and not OP like some of the other mods, Very vanillish IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants