Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen 3 Breeding PID Legality #3092

Closed
StarfBerry opened this issue Nov 20, 2020 · 8 comments
Closed

Gen 3 Breeding PID Legality #3092

StarfBerry opened this issue Nov 20, 2020 · 8 comments

Comments

@StarfBerry
Copy link

StarfBerry commented Nov 20, 2020

Recently I rng'd a Kingdra from the Battle Pyramid and I caught it in a Poké Ball using the Pomeg Glitch.
When I read my Emerald save file with PKHeX, the Kingdra is considered as illegal and that makes sense.
But when I transfer it into Gen 4 he's still considered as illegal cause of "PID mismatch".
So I checked if the PID and IVs of my Kindgra were possible via breeding in Emerald and yes it can.
Emerald Breeding RNG Process : https://github.com/Admiral-Fish/PokeFinder/blob/master/Core/Gen3/Generators/EggGenerator3.cpp#L131

To support my words I was able to rng'd a Horsea egg with the same pid/ivs that the Kingdra using lua script + battle video.
Screenshot_1
Screenshot_4

And PKHeX considered it as illegal. I use the last PKHeX version.
Screenshot_2

@StarfBerry StarfBerry added the bug label Nov 20, 2020
@kwsch
Copy link
Owner

kwsch commented Nov 21, 2020

Not a bug. Please do not report invalid encounters being flagged as invalid; they are flagged as invalid for a reason.

Hold control to see that your PIDIV is incompatible with the encounter it was matched to, hence the Encounter Type PID mismatch.

@kwsch kwsch closed this as completed Nov 21, 2020
@StarfBerry
Copy link
Author

I don't understand.
The Horsea egg has been generated by the game without any modification on my part.
So this PID + IVs can be obtained via breeding in Emerald.
There is something wrong in the legality check for eggs in Emerald.

@StarfBerry
Copy link
Author

StarfBerry commented Nov 21, 2020

Okay I think I got it.
If you generate an egg which matches with PID/IVs of an other RNG Method like XD/Colo or Method 1/2/4, the egg is considered as illegal.
Screenshot_7
Screenshot_5
And as you can see this IV spread can be obtained with this PID if you have the adequate parents (pid and ivs are generated separetly).

Screenshot_10
Screenshot_8
Screenshot_9

This explain the issue with my previous Horsea. He has all characteristics of a Method H-2.

@kwsch
Copy link
Owner

kwsch commented Nov 21, 2020

Yeah, and it's not statistically probable to get a 1:billion match, hence the flag.

@StarfBerry
Copy link
Author

But these eggs must be considered as legal.
They can be generated without using an external tool.

@StarfBerry StarfBerry changed the title Emerald Breeding PID Legality Gen 3 Breeding PID Legality Nov 21, 2020
@kwsch
Copy link
Owner

kwsch commented Nov 22, 2020

No they cannot be obtained without an external tool or unnecessary manipulation -- you are unable to change parents once the egg is ready for pickup (PID set).

Again, the statistical improbability of randomly getting a PIDIV correlation is exponentially lower than the chance that someone hacks something with a PIDIV incorrectly.

@StarfBerry
Copy link
Author

StarfBerry commented Nov 22, 2020

The first shiny Horsea has been obtained with only rng manipulations.
I rng'd both parents and I deposited them at the day care.
And I used the battle video to coincide the PRNG state with the timer value to get my target pid.
Finally I got the right ivs using PokéFinder, a rng tool.
So the egg has clearly not been hacked or something else.
This can be replicate without any rng manips. The odds are extremely low I agree but that's possible.

@kwsch
Copy link
Owner

kwsch commented Nov 22, 2020

Just because you can doesn't mean you should.

Repository owner locked as resolved and limited conversation to collaborators Nov 22, 2020
@Lusamine Lusamine removed the bug label Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants