refactor: internal refactors

WSLDiskShrinker/Common/BooleanToInverseVisibilityConverter.cs

@@ -5,15 +5,13 @@ namespace WSLDiskShrinker.Common;
 
 class BooleanToInverseVisibilityConverter : IValueConverter
 {
-	public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
-	{
-		bool v = (bool) value;
-		return v ? Visibility.Collapsed : Visibility.Visible;
-	}
+    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return (bool)value ? Visibility.Collapsed : Visibility.Visible;
+    }
 
-	public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-	{
-		throw new NotImplementedException();
-	}
+    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return (bool)value ? Visibility.Visible : Visibility.Collapsed; // Not used.
+    }
 }
-

WSLDiskShrinker/Common/BooleanToVisibilityConverter.cs

@@ -5,15 +5,13 @@ namespace WSLDiskShrinker.Common;
 
 class BooleanToVisibilityConverter : IValueConverter
 {
-	public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
-	{
-		bool v = (bool)value;
-		return v ? Visibility.Visible : Visibility.Collapsed;
-	}
+    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return (bool)value ? Visibility.Visible : Visibility.Collapsed;
+    }
 
-	public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-	{
-		throw new NotImplementedException();
-	}
+    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return (bool)value ? Visibility.Collapsed : Visibility.Visible; // Not used.
+    }
 }
-

WSLDiskShrinker/Common/CommandFailedException.cs

@@ -1,11 +1,21 @@
-namespace WSLDiskShrinker.Common;
+using System.Runtime.Serialization;
 
-public class CommandFailedException : Exception
+namespace WSLDiskShrinker.Common;
+
+[Serializable]
+public class CommandFailedException : Exception /* ISerializable */
 {
-	public Process FailedProcess { get; set; }
-	public CommandFailedException(Process p)
-	{
-		this.FailedProcess = p;
-	}
-}
+    public Process? FailedProcess { get; }
+    public CommandFailedException(Process p)
+    {
+        this.FailedProcess = p;
+    }
 
+    // Implement exception constructors (not used).
+    public CommandFailedException() : base() { }
+    public CommandFailedException(string? message) : base(message) { }
+    public CommandFailedException(string? message, Exception? innerException) : base(message, innerException) { }
+
+    // ISerializable should be implemented (not used).
+    protected CommandFailedException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+}

WSLDiskShrinker/Common/NotConverter.cs

@@ -5,15 +5,13 @@ namespace WSLDiskShrinker.Common;
 
 class NotConverter : IValueConverter
 {
-	public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
-	{
+    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return !(bool)value;
+    }
 
-		return !(bool)value;
-	}
-
-	public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-	{
-		throw new NotImplementedException();
-	}
+    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    {
+        return !(bool)value; // Not used.
+    }
 }
-

WSLDiskShrinker/Common/ProcessExtension.cs

@@ -1,29 +1,27 @@
-using System.Threading;
+#if !NET5_0_OR_GREATER
+
+using System.Threading;
 
 namespace WSLDiskShrinker.Common;
 
 // https://stackoverflow.com/questions/470256/process-waitforexit-asynchronously
 static class ProcessExtension
 {
-	/// <summary>
-	/// Waits asynchronously for the process to exit.
-	/// </summary>
-	/// <param name="process">The process to wait for cancellation.</param>
-	/// <param name="cancellationToken">A cancellation token. If invoked, the task will return 
-	/// immediately as canceled.</param>
-	/// <returns>A Task representing waiting for the process to end.</returns>
-	public static Task CustomWaitForExitAsync(this Process process,
-		CancellationToken cancellationToken = default)
-	{
-		if (process.HasExited) return Task.CompletedTask;
+    /// <summary>Waits asynchronously for the process to exit.</summary>
+    /// <param name="process">The process to wait for cancellation.</param>
+    /// <param name="cancellationToken">A cancellation token. If invoked, the task will return immediately as canceled.</param>
+    /// <returns>A Task representing waiting for the process to end.</returns>
+    public static Task CustomWaitForExitAsync(this Process process, CancellationToken cancellationToken = default)
+    {
+        if (process.HasExited) return Task.CompletedTask;
 
-		var tcs = new TaskCompletionSource<object>();
-		process.EnableRaisingEvents = true;
-		process.Exited += (sender, args) => tcs.TrySetResult(null);
-		if (cancellationToken != default)
-			cancellationToken.Register(() => tcs.SetCanceled());
+        var tcs = new TaskCompletionSource<object>();
+        process.EnableRaisingEvents = true;
+        process.Exited += (sender, args) => tcs.TrySetResult(process.ExitCode);
+        if (cancellationToken != default) cancellationToken.Register(() => tcs.SetCanceled());
 
-		return process.HasExited ? Task.CompletedTask : tcs.Task;
-	}
+        return process.HasExited ? Task.CompletedTask : tcs.Task;
+    }
 }
 
+#endif