Feature/14 model spec #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| describe 'スコープ' do | ||
| describe 'body_contain' do | ||
| let!(:post) { create(:post, body: 'hello world') } | ||
| subject { Post.body_contain('hello') } |
There was a problem hiding this comment.
感覚的な回答をしますが、subjectを使うのはおしゃれですね！
ただ、あくまで個人的な印象ですが、subjectはあまり限定的に使わないイメージです。
使うのであれば統一して使って、テスト対象を明確させるために使うイメージです！
あと、職歴浅いので話1/3ぐらいで聴いてもらいたいですが、subjectを絶対使う派閥がいたり、いなかったりするみたいです。
このあたりは流派が分かれるらしいです。
伊藤淳一さんは使わない派閥らしいですが、すぐ見つかった参考記事を貼っておきます！
https://blog.jnito.com/entry/2021/10/09/105651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
レビューよろしくお願いします。