Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting YES/NO to true/false #7

Merged
merged 1 commit into from May 23, 2013

Conversation

ivanacostarubio
Copy link
Contributor

I hope this help! :-)

@kyamaguchi
Copy link
Owner

Thanks a lot.
I will merge this.

And also I will change expression a little later.

     def convert_boolean(self):
-        self.s = re.sub('YES','true', self.s)
-        self.s = re.sub('NO','false', self.s)
+        self.s = re.sub(r'\bYES\b','true', self.s)
+        self.s = re.sub(r'\bNO\b','false', self.s)
         return self

This will avoid unexpected replacement of YES/NO in words like 'ZNOAuth' or something else.

kyamaguchi added a commit that referenced this pull request May 23, 2013
Converting YES/NO to true/false
@kyamaguchi kyamaguchi merged commit f3d16a3 into kyamaguchi:master May 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants