Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized constant Ghn::ReleaseNotification::JSON (NameError) #37

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Fix uninitialized constant Ghn::ReleaseNotification::JSON (NameError) #37

merged 1 commit into from
Jun 9, 2015

Conversation

masutaka
Copy link
Contributor

@masutaka masutaka commented Jun 8, 2015

I found the following problem.

$ ghn list
/Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/notification.rb:71:in `url': uninitialized constant Ghn::ReleaseNotification::JSON (NameError)
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/collector.rb:20:in `block in collect'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/collector.rb:19:in `map'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/collector.rb:19:in `collect'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/commands.rb:33:in `block in collect'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/commands.rb:32:in `loop'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/commands.rb:32:in `with_index'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/commands.rb:32:in `collect'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/lib/ghn/commands.rb:12:in `list'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
        from /Users/masutaka/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/ghn-2.4.0/bin/ghn:5:in `<top (required)>'
        from /Users/masutaka/.rbenv/versions/2.2.2/bin/ghn:23:in `load'
        from /Users/masutaka/.rbenv/versions/2.2.2/bin/ghn:23:in `<main>'

When I have a release notification(ex. https://github.com/kyanny/ghn/releases/tag/v2.4.0), this problem occurs.

kyanny added a commit that referenced this pull request Jun 9, 2015
Fix uninitialized constant Ghn::ReleaseNotification::JSON (NameError)
@kyanny kyanny merged commit 9c9d72c into kyanny:master Jun 9, 2015
@kyanny
Copy link
Owner

kyanny commented Jun 9, 2015

@masutaka
Copy link
Contributor Author

masutaka commented Jun 9, 2015

Welcome!

@masutaka masutaka deleted the fix-uninitialized-constant branch June 9, 2015 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants