fix: make max buffer size refer to byte length not string length

kyarik · Jun 2, 2021 · 5eb753b · 5eb753b
1 parent 6112d26
commit 5eb753b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/__tests__/index.ts b/src/__tests__/index.ts
@@ -1388,7 +1388,7 @@ function runTests(createApp: () => App): void {
       app.post(endpoint(), persistedQueries({ queryMap }), graphqlHTTP({ schema }));
 
       // eslint-disable-next-line @typescript-eslint/no-magic-numbers
-      const body = Buffer.alloc(100 * UNIT_KIB + 1, 'a').toString();
+      const body = Buffer.alloc(100 * UNIT_KIB + 1, 'I ♥ GraphQL').toString();
 
       const response = await request(app).post(endpoint()).type('json').send(body);
 
@@ -1408,7 +1408,7 @@ function runTests(createApp: () => App): void {
       app.post(endpoint(), persistedQueries({ queryMap }), graphqlHTTP({ schema }));
 
       // eslint-disable-next-line @typescript-eslint/no-magic-numbers
-      const body = Buffer.alloc(100 * UNIT_KIB, 'a').toString();
+      const body = Buffer.alloc(100 * UNIT_KIB, 'I ♥ GraphQL').toString();
 
       const response = await request(app).post(endpoint()).type('json').send(body);
 

diff --git a/src/parseRequestBodyIfNecessary.ts b/src/parseRequestBodyIfNecessary.ts
@@ -62,9 +62,9 @@ async function readRawBody(req: Request, contentTypeInfo: ParsedMediaType): Prom
   const stream = getStreamFromRequest(req, encoding);
 
   try {
-    const body = await getStream(stream, { encoding: charset, maxBuffer });
+    const bodyBuffer = await getStream.buffer(stream, { maxBuffer });
 
-    return body;
+    return bodyBuffer.toString(charset);
   } catch (unknownError: unknown) {
     /* istanbul ignore else: cannot make get-stream throw other error. */
     if (unknownError instanceof MaxBufferError) {