Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when object is destroyed or destroying #191

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix exception when object is destroyed or destroying #191

merged 2 commits into from
Dec 2, 2019

Conversation

ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Nov 27, 2019

As run is an async function, There is no guarantee that the attach-popover still exist. So we need to duplicate the check.

@tylerturdenpants tylerturdenpants merged commit 39e0a85 into tylerturdenpants:master Dec 2, 2019
@ctjhoa ctjhoa deleted the fix_exception branch December 2, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctjhoa @tylerturdenpants