Pass correct popper element in the registerAPI #105

[urbany]

Fixes #105

[simonihmig]

Thanks @urbany for working on this! Indeed my latest changes seem to have introduced this. 😔

Apparently there is some missing test coverage. Would you be able to add a test case to https://github.com/kybishop/ember-popper/blob/master/tests/integration/components/ember-popper/register-api-test.js?

Also another test is failing here, but this might be the flakey one of #95. I already restarted Travis a number of times though...

[simonihmig]

I already restarted Travis a number of times though...

Ah yes, it has finally passed after the third retry 🤔. So seems not related...

[urbany]

@simonihmig test added (I confirmed the test fails without the fix) and passes with the fix. I noticed that some tests fail randomly, but all pass most times.

PS: Thank you for your work on this addon!

[simonihmig]

Awesome, thanks @urbany!

[simonihmig]

The failing test in Ember 2.18 is from the newly added test. It seems https://github.com/kybishop/ember-popper/pull/106/files#diff-255dc3991591e84507576a55a13a6173R52 returns null here!? 🤔

[urbany]

@simonihmig I tried to fix this but couldn't, don't know what's wrong sorry :s

[simonihmig]

@urbany I added a commit to your PR that should hopefully fix the failing test! It is related to a bug in ember-angle-bracket-invocation-polyfill (used in the Ember 2.18 test scenario), which makes the attributes (here class) render after didRender.

Let's see what Travis thinks of this...

[simonihmig]

Published as 0.10.1! 🎉

[urbany]

@simonihmig great! Thank you for the help!