Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-ref-modifier to 1.0 #117

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Conversation

simonihmig
Copy link
Collaborator

Supersedes #114

@simonihmig
Copy link
Collaborator Author

@jrjohnson I used your previous work here, and got (most) failing tests fixed. The issue seemed to be that ref is setting asynchronously (see https://github.com/lifeart/ember-ref-modifier/blob/master/addon/modifiers/ref.js#L72), so a few settled() calls in tests were able to fix this.

However tests for Ember 2.18 and 3.4 are still failing. Seems ember-ref-modifier does not support these, and also seems you know about it! 😝lifeart/ember-ref-modifier#199

Any specific reasons to not support the older versions anymore? Not sure we can drop support here already!? 🤔

@jrjohnson
Copy link
Contributor

Nice! Passing tests always better.

If I'm understanding the list correctly then 3.12 is the only currently supported LTS. Anyone still using an older version of ember can just stay on an earlier version of this addon.

ref-modifier probably runs on 3.12 just fine, but it can't be tested against it because there is no polyfill for setComponentTemplate so the glimmer component tests in the addon fail. That's why I bumped the min version to 3.13. No tests / no guarantees.

@simonihmig
Copy link
Collaborator Author

ref-modifier probably runs on 3.12 just fine

Indeed, also tests for 3.8 were passing. Thanks for the explanation! I was a bit hesitant to drop support for 3.12, as we should have at least the latest LTS supported. But as it seems to work fine, we can keep it. Here's a PR for dropping the older versions: #119

@simonihmig simonihmig force-pushed the jrjohnson-updte-ref-modifier branch 2 times, most recently from 41313f2 to b925b1f Compare February 9, 2020 22:22
jrjohnson and others added 2 commits February 10, 2020 00:02
The breaking change in this version was a parameter re-ordering that is
already fixed here.
@simonihmig simonihmig merged commit 5b5836c into master Feb 9, 2020
@simonihmig simonihmig deleted the jrjohnson-updte-ref-modifier branch February 9, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants