Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile; add command line parsing #182

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Add Dockerfile; add command line parsing #182

merged 3 commits into from
Dec 13, 2023

Conversation

reinoud
Copy link
Contributor

@reinoud reinoud commented Dec 12, 2023

Proposed changes

  • To enable isolation of the installation, a Dockerfile is added to build a container.
  • Since the container runs in a different environment, command-line arguments were added to facilitate output files in a different location. The default behaviour and normal usage of the script was not changed

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • Add or update tests that prove the fix is effective or that the feature works
  • Add or update workflows for deployment
  • Add or update README, CHANGELOG

Outcome

  • The README now has a section with the usage and output when running the docker image from the command line

Copy link
Owner

@kyhau kyhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @reinoud!

@kyhau kyhau merged commit cb7ecc7 into kyhau:main Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants