Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working zstd support! #2

Closed
wants to merge 1 commit into from
Closed

Working zstd support! #2

wants to merge 1 commit into from

Conversation

kylebarron
Copy link
Owner

@kylebarron kylebarron commented Mar 4, 2022

Needs this unreleased commit from zstd-rs, which was merged on Jan 28, and didn't make it into version 0.10.0.

It also needs default-features = false on zstd. That will be a change necessary in arrow-rs. It looks like the only string of zstd:: in arrow-rs is in parquet/src/compression.rs, and that seems to work fine with default-features=false. So this update in Arrow shouldn't be an issue.

Also needs to use the non-Apple clang for compiling. Ref rust-bitcoin/rust-secp256k1#283 (comment) and rust-bitcoin/rust-secp256k1#283 (comment) and the upstream zstd issue gyscos/zstd-rs#93. When only PATH was updated but not CC or AR, I got error: failed to build archive: section too large.

Repro:

brew install llvm
export PATH="/usr/local/opt/llvm/bin/:$PATH"
export CC=/usr/local/opt/llvm/bin/clang
export AR=/usr/local/opt/llvm/bin/llvm-ar

@kylebarron
Copy link
Owner Author

kylebarron commented Mar 16, 2022

Closing, as the updated zstd version is in progress upstream. The next versions of the parquet and parquet2 crates will hopefully depend on 0.11.1+ and use default-features = false.

@kylebarron kylebarron closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant