Fixes for both report builds and PR comment workflow #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it expected that CI on this PR still fails? |
kylebarron
approved these changes
Apr 9, 2024
Account for broken asset generation in target branch
|
Alright, resolved for cases where the target branch has output asset manifests literally containing null.
Yep, both the slim and sync builds were previously overestimating the bundle size (by ~all compressions + async for slim, all compressions for sync). Should be much more accurate now. |
…er' (sans compressions, unlike prior builds that did not exclude default features). Also correct the sync report build 😞
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report builds should resolve properly in this PR's actions, the PR comment stuff will only work after merging.