Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Pull in upstream changes to curlExec() #20

Closed

Conversation

jacobembree
Copy link

ServicesWebTestCase::curlExec() is missing the changes made upstream to DrupalWebTestCase::curlExec().
See https://www.drupal.org/node/889338.

@signalpoint
Copy link
Collaborator

@jacobembree Thanks. Should this land as a patch on d.o instead of over here on GitHub? Don't get me wrong, I love pull requests and think they're way easier to deal with, it's just away from the typical Drupal protocol (until they are running full blown GitLab).

@jacobembree
Copy link
Author

Either way works for me. The project page says to use GitHub, but different people probably monitor different places.
The Drupal.org issue for this is #3027087.

@jacobembree
Copy link
Author

Thanks for committing this at Drupal.org, @signalpoint. I'm closing this pull request since Drupal.org is where development is happening.
See https://www.drupal.org/project/services/issues/3027094 where I recommend removing mention of this repository.

@signalpoint
Copy link
Collaborator

Thank you @jacobembree , I hadn't noticed the mention of preferred development over here. I believe it's mostly for the D8 version which Kyle maintains. I cleared up the verbiage on the d.o project page to clarify D8 is over here and D7 is over there.

@jacobembree jacobembree deleted the 7.x-3.x-curlExec branch February 21, 2019 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants