-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom surround <M-]>
doesn't work since v2.1.3
#325
Labels
bug
Something isn't working
Comments
bew
added a commit
to bew/nvim-surround
that referenced
this issue
May 27, 2024
`getcharstr()` already returns raw internal termcodes, it is wrong to call nvim_replace_termcodes on its result. This effectively reverts PR kylechui#273 refs: neovim/neovim#29034 fixes: kylechui#325
bew
added a commit
to bew/nvim-surround
that referenced
this issue
May 27, 2024
`getcharstr()` already returns raw internal termcodes, it is wrong to call nvim_replace_termcodes on its result. This effectively reverts PR kylechui#273 refs: neovim/neovim#29034 fixes: kylechui#325
kylechui
pushed a commit
to bew/nvim-surround
that referenced
this issue
May 29, 2024
`getcharstr()` already returns raw internal termcodes, it is wrong to call nvim_replace_termcodes on its result. This effectively reverts PR kylechui#273 refs: neovim/neovim#29034 fixes: kylechui#325
kylechui
pushed a commit
to bew/nvim-surround
that referenced
this issue
May 30, 2024
`getcharstr()` already returns raw internal termcodes, it is wrong to call nvim_replace_termcodes on its result. This effectively reverts PR kylechui#273 refs: neovim/neovim#29034 fixes: kylechui#325
bew
added a commit
to bew/nvim-surround
that referenced
this issue
May 30, 2024
`getcharstr()` already returns raw internal termcodes, it is wrong to call nvim_replace_termcodes on its result. This effectively reverts PR kylechui#273 refs: neovim/neovim#29034 fixes: kylechui#325
kylechui
pushed a commit
that referenced
this issue
May 30, 2024
* Don't translate termcodes twice on input `getcharstr()` already returns raw internal termcodes, it is wrong to call nvim_replace_termcodes on its result. This effectively reverts PR #273 refs: neovim/neovim#29034 fixes: #325 * Add tests for multi-byte mappings
Oh yeah I just tagged this change under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
:h nvim-surround
to see if there might be any relevant information there?Neovim Version
Plugin Version
Tagged (Stable)
Minimal Configuration
(note I use these in Lua files, to ease changing
[[ ... ]]
-based strings)Sample Buffer
Keystroke Sequence
fb
cs
<M-[>
<M-]>
ds
<M-]>
Expected behavior
[[foobar]]
foobar
Actual behavior
Nothing happens
Additional context
I bisected the issue to cfa2da7
And neovim devs mentioned to me that calling
nvim_replace_termcodes
on the result ofgetcharstr
is wrong, the output ofgetcharstr
is already the raw chars!See neovim/neovim#29034
The text was updated successfully, but these errors were encountered: