Merge pull request #36 from kyledecot/kd-factory-not-registered

Refactor FactoryNotRegistered
kyledecot · Jul 4, 2019 · 1e11c3f · 1e11c3f
2 parents 4afd175 + 008abbc
commit 1e11c3f
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/lib/app_store_connect/factory.rb b/lib/app_store_connect/factory.rb
@@ -2,7 +2,11 @@
 
 module AppStoreConnect
   class Factory
-    BuilderNotRegistered = Class.new(StandardError)
+    class BuilderNotRegistered < StandardError
+      def initialize(name)
+        super("Builder not registered: #{name}")
+      end
+    end
 
     def self.register(name, builder)
       builders[name] = builder
@@ -13,11 +17,9 @@ def self.builders
     end
 
     def self.build(name, options = {})
-      builder = builders[name]
-
-      raise BuilderNotRegistered, "Builder not registered: #{name}" if builder.nil?
-
-      builder.call(options)
+      builders.fetch(name) do
+        raise BuilderNotRegistered, name
+      end.call(options)
     end
   end
 end