Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Included Concern #135

Merged
merged 9 commits into from
Feb 26, 2023
Merged

Create Included Concern #135

merged 9 commits into from
Feb 26, 2023

Conversation

kyledecot
Copy link
Owner

No description provided.

@kyledecot kyledecot mentioned this pull request Feb 15, 2023
Closed
gregg-platogo
gregg-platogo suggested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@gregg-platogo gregg-platogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man just check it out on our end and it works like a charm. Just few questions and pointers 😉

spec/bundle_id_create_request_spec.rb Show resolved Hide resolved
lib/app_store_connect/modify_request.rb Outdated Show resolved Hide resolved
lib/app_store_connect.rb Outdated Show resolved Hide resolved
lib/app_store_connect/object/included.rb Show resolved Hide resolved
@kyledecot kyledecot marked this pull request as ready for review February 26, 2023 16:39
@kyledecot kyledecot merged commit 77baf6d into main Feb 26, 2023
@kyledecot kyledecot deleted the kd-included branch February 26, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregg-platogo gregg-platogo gregg-platogo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyledecot @gregg-platogo