Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't better use URITemplate 2.0.0 in last tag? #70

Closed
RafaelPlantard opened this issue Nov 9, 2016 · 6 comments
Closed

Isn't better use URITemplate 2.0.0 in last tag? #70

RafaelPlantard opened this issue Nov 9, 2016 · 6 comments
Labels

Comments

@RafaelPlantard
Copy link

In 1.3.0 release and master branch you're using URI Template 2.0.0, but when I use the last tag (1.3.1) the URITemplate dependency used is 1.4.0. Isn't better use also version 2.0.0 in last tag?

@kylef kylef added the question label Nov 9, 2016
@kylef
Copy link
Owner

kylef commented Nov 9, 2016

URITemplate 2.0 requires Swift 3.0. Mockingjay 1.3.1 is for Swift 2.3, therefore URITemplate 2 isn't compatible with Mockingjay 1.x.

@RafaelPlantard
Copy link
Author

I got your point, thanks for your time... Just another question, the new releases will be build to Swift 3 with URITemplate 2.0?

@kylef
Copy link
Owner

kylef commented Nov 9, 2016

Yes, there will be a new version of Mockingjay (2.0.0) which will add Swift 3 support. If you're currently using Swift 3, you can actually use Mockingjay from master which has Swift 3 support.

In CocoaPods that can be done via:

pod 'Mockingjay', :git => 'https://github.com/kylef/Mockingjay.git'

The reason the current master hasn't been released is due to the problems some users have discovered in #65 which I'd like to address first. I don't have the time this project deserves to handle this right now.

@RafaelPlantard
Copy link
Author

I understand, I'm using this approach.. Thanks..

@kylef
Copy link
Owner

kylef commented Nov 9, 2016

I think this problem may have been resolved so I should be able to make a release soon.

Please let me know if you find any issues with Mockingjay in Swift 3.

@MedAmineWinners
Copy link

@kylef can we fix warnings on URITemplate for swift 4 and upper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants