Build XCTest extensions on linux #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottwilliams
force-pushed
the
xctest-linux
branch
from
c37f0f7
to
ac56ae9
Compare
elliottwilliams
force-pushed
the
xctest-linux
branch
from
ac56ae9
to
36eabdd
Compare
kylef
approved these changes
Nov 18, 2020
|
Thanks @elliottwilliams that's awesome! |
|
I've released this in Spectre 0.9.2 |
|
Sweet! Thanks for the quick release turnaround 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, swift-corelibs-xctest exists, so it should be possible to use Spectre from XCTest on Linux. This change removes the #if guards around XCTest extensions, with the exception of some Xcode 12+ APIs that have not yet made it upstream.
Testing done
Builds and tests on a linux machine using the official Swift docker images: