Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tag with Environment changes #93

Closed
dannylewis-sheffield opened this issue Jan 17, 2017 · 7 comments
Closed

New tag with Environment changes #93

dannylewis-sheffield opened this issue Jan 17, 2017 · 7 comments

Comments

@dannylewis-sheffield
Copy link

Hi

Can you tag the code if you think it's stable with the Environment changes.

Thanks

@kylef
Copy link
Collaborator

kylef commented Jan 18, 2017

I don't think anything is stable until 1.0, there's various issues left to tackle: https://github.com/kylef/Stencil/milestones/1.0.0

@dannylewis-sheffield
Copy link
Author

Fair comment, I'm keen to use the Environment changes and am using SPM so a tag is needed. Do you think it could be tagged as 0.7.3? I agree 1.0.0 is considered first stable.

Thanks

@timburks
Copy link

+1

I'm using Stencil in the plugin for Swift gRPC support and temporarily forked-and-tagged Stencil to get the Environment changes. I'd much rather refer to a tag here.

p.s. thanks for Stencil!

@AliSoftware
Copy link
Collaborator

Hi @kylef 👋

We too will need a tag as well in order to be able to release StencilSwiftKit 1.0 — which will be then used both for SwiftGen and Sourcery — so even a 0.8.0 tag soon would be very welcome if you could! (\cc @djbe)

Thanks! 😉

@kylef
Copy link
Collaborator

kylef commented Feb 18, 2017

https://github.com/kylef/Stencil/releases/tag/0.8.0

@kylef kylef closed this as completed Feb 18, 2017
@AliSoftware
Copy link
Collaborator

🎉 thanks!

@AliSoftware
Copy link
Collaborator

Just FYI @kylef there's some warnings in Stencil when linting the pod with CP.
e.g. when I lint StencilSwiftKit, which depends on 'Stencil', '~> 0.8.0', I got the following warnings when linting, and those seems to come from Stencil itself:

Validating podspec
 -> StencilSwiftKit (1.0.0)
    - NOTE  | [OSX] xcodebuild:  <unknown>:0: warning: expression implicitly coerced from 'Any?' to Any
    - NOTE  | [OSX] xcodebuild:  <unknown>:0: note: provide a default value to avoid this warning
    - NOTE  | [OSX] xcodebuild:  <unknown>:0: note: force-unwrap the value to avoid this warning
    - NOTE  | [OSX] xcodebuild:  <unknown>:0: note: explicitly cast to Any with 'as Any' to silence this warning
    - WARN  | [OSX] xcodebuild:  Stencil/Sources/Loader.swift:55:14: warning: no calls to throwing functions occur within 'try' expression
    - WARN  | [OSX] xcodebuild:  Stencil/Sources/Loader.swift:68:18: warning: no calls to throwing functions occur within 'try' expression

Not a huge deal, but it's always nice to reduce the noise whenever possible for next release 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants