Fix Swift 4 compilation error #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dcwatson, Thanks for the PR. Would you be able to add an extra testing matrix for Xcode 9.1 since this problem is only with that version of Xcode (if I understand correctly). You can copy the lines from https://github.com/kylef/Stencil/blob/master/.travis.yml#L6-L8 and update for Xcode 9. |
OneSman7
approved these changes
Nov 17, 2017
|
Waiting for this to be released in pod. |
|
Welp, the xcode9.1 tests ran successfully, not sure why the Swift 4 linux tests started failing, I didn't change anything else... |
|
Thanks! And thanks for the project, it's feels like home as a Django guy getting his feet wet with Swift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing 0.10.0 on Xcode 9.1/Swift 4 results in a compilation error to the effect of "Swift 4 subscripts returning string obsoleted". Not sure if this was a more recent change in 9.1, since I see you're already testing on Xcode 9.