-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow where_in and where_not_in to have empty arrays #34
Comments
Would you rather it just silently ignore it? |
Yes. Ignore will be great. No need to encode in SQL. |
…ve travis build sqlserver as well (hopefull).
This is officially fixed in the v2 branch. Beta should be out soon. |
@Flamenco Thank you for being so active in reporting issues. A v2 Beta is officially out on NPM. If you wouldn't mind testing it, that would be very much appreciated. You can install the beta like so:
If you need to submit issues for it, please prefix the issue with v2Beta: Thanks again! |
@kylefarris I am not sure how you implemented this, but maybe instead of ignoring, replace where_in('foo', []) with false or (1=0) and where_not_in('foo', []) with true or (1=1). I am about to switch over to v2 and I have some complex queries that may have issues. |
…ve travis build sqlserver as well (hopefull).
I have to put many checks in my code for filters because where_in('foo',[]) will throw an error.
Please consider allowing these conditions.
The text was updated successfully, but these errors were encountered: