Skip to content

Commit

Permalink
#463 overhauled featured image setting
Browse files Browse the repository at this point in the history
  • Loading branch information
@kylegilman
kylegilman committed Jan 27, 2023
1 parent 876d750 commit 6baf024
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 29 deletions.
10 changes: 10 additions & 0 deletions src/admin/js/videopack-admin.js
View file
Expand Up @@ -30,6 +30,16 @@ function kgvid_admin_page_ready() {
kgvid_attachment_selected(attributes);
}
});
wp.media.frame.on('attachment:compat:ready', function() {
var attributes = wp.media.frame.state().get('selection').first().attributes;
var thumb_id = jQuery('#thumbnail-' + attributes.id).data('thumb_id');
if ( jQuery('#thumbnail-'+attributes.id).data('featuredchanged') == true
&& jQuery('#attachments-' + attributes.id + '-featured').attr('checked')
&& thumb_id
) {
wp.media.featuredImage.set(thumb_id);
}
});
wp.media.frame.state().get('library').on('reset', function() {
wp.media.frame.trigger('selection:toggle');
});
Expand Down
63 changes: 34 additions & 29 deletions src/admin/videopack-admin.php
View file
Expand Up @@ -425,16 +425,22 @@ function kgvid_save_attachment_meta( $post_id, $kgvid_postmeta ) {

foreach ( $kgvid_postmeta as $key => $meta ) { // don't save if it's the same as the default values or empty

if ( ( array_key_exists( $key, $options ) && $meta == $options[ $key ] )
|| ( ! is_array( $kgvid_postmeta[ $key ] ) && strlen( $kgvid_postmeta[ $key ] ) == 0
&& ( ( array_key_exists( $key, $options ) && strlen( $options[ $key ] ) == 0 )
|| ! array_key_exists( $key, $options ) )
if ( ( array_key_exists( $key, $options )
&& $meta == $options[ $key ]
)
|| ( ! is_array( $kgvid_postmeta[ $key ] )
&& strlen( $kgvid_postmeta[ $key ] ) === 0
&& (
( array_key_exists( $key, $options )
&& strlen( $options[ $key ] ) === 0
)
|| ! array_key_exists( $key, $options )
)
)
) {
unset( $kgvid_postmeta[ $key ] );
}
}

update_post_meta( $post_id, '_kgvid-meta', $kgvid_postmeta );

}
Expand Down Expand Up @@ -2865,7 +2871,9 @@ function kgvid_upload_page_change_thumbnail_parent( $location ) {

kgvid_change_thumbnail_parent( $post_id, $parent_id );

if ( $options['featured'] == 'on' && ! has_post_thumbnail( $parent_id ) ) {
if ( $options['featured'] == 'on'
&& ! has_post_thumbnail( $parent_id )
) {
$featured_id = get_post_meta( $post_id, '_kgflashmediaplayer-poster-id', true );
if ( ! empty( $featured_id ) ) {
set_post_thumbnail( $parent_id, $featured_id );
Expand All @@ -2878,7 +2886,7 @@ function kgvid_upload_page_change_thumbnail_parent( $location ) {
}
add_filter( 'wp_redirect', 'kgvid_upload_page_change_thumbnail_parent' ); // when attachment parent is manually changed on the Media Library page

function kgvid_validate_post_updated( $post_id ) {
function kgvid_validate_attachment_updated( $post_id ) {

$options = kgvid_get_options();
$post = get_post( $post_id );
Expand All @@ -2890,15 +2898,18 @@ function kgvid_validate_post_updated( $post_id ) {
kgvid_change_thumbnail_parent( $post_id, $post->post_parent );
}

if ( $options['featured'] == 'on' ) {
$featured_id = get_post_meta( $post_id, '_kgflashmediaplayer-poster-id', true );
if ( ! empty( $featured_id ) && get_post_thumbnail_id( $post->post_parent ) != $featured_id ) {
set_post_thumbnail( $post->post_parent, $featured_id );
}
$featured_id = get_post_meta( $post_id, '_kgflashmediaplayer-poster-id', true );
$kgvid_postmeta = kgvid_get_attachment_meta( $post_id );
//this doesn't always get set in the old Media Library view
set_post_thumbnail( $post_id, $featured_id );
if ( $kgvid_postmeta['featuredchanged'] === 'true'
&& ! empty( $featured_id )
) {
set_post_thumbnail( $post->post_parent, $featured_id );
}
}
}
add_action( 'edit_attachment', 'kgvid_validate_post_updated' );
add_action( 'edit_attachment', 'kgvid_validate_attachment_updated' );

/**
* Adding our custom fields to the $form_fields array
Expand Down Expand Up @@ -3017,7 +3028,7 @@ function kgvid_image_attachment_fields_to_edit( $form_fields, $post ) {
if ( ! empty( $kgvid_postmeta['autothumb-error'] ) && empty( $thumbnail_url ) ) {
$thumbnail_html = '<div class="kgvid_thumbnail_box kgvid_chosen_thumbnail_box">' . wp_kses_post( $kgvid_postmeta['autothumb-error'] ) . '</div>';
} elseif ( ! empty( $thumbnail_url ) ) {
$thumbnail_html = '<div class="kgvid_thumbnail_box kgvid_chosen_thumbnail_box"><img width="200" data-thumb_id="' . esc_attr( $thumbnail_id ) . '" src="' . esc_attr( $thumbnail_url ) . '?' . rand() . '"></div>';
$thumbnail_html = '<div class="kgvid_thumbnail_box kgvid_chosen_thumbnail_box"><img id="thumbnail-' . esc_attr( $post->ID ) . '" width="200" data-thumb_id="' . esc_attr( $thumbnail_id ) . '" data-featuredchanged="' . esc_attr( $kgvid_postmeta['featuredchanged'] ) . '" src="' . esc_attr( $thumbnail_url ) . '?' . rand() . '"></div>';
}

$choose_from_video_content = '';
Expand All @@ -3038,7 +3049,7 @@ function kgvid_image_attachment_fields_to_edit( $form_fields, $post ) {
&& ! $thumbnail_url
&& $created_time < 60
) {
$thumbnail_html = '<div class="kgvid_thumbnail_box kgvid_chosen_thumbnail_box kgvid_redraw_thumbnail_box" style="height:112px;"><span>' . esc_html__( 'Loading thumbnail...' ) . '</span></div>';
$thumbnail_html = '<div id="thumbnail-' . esc_attr( $post->ID ) . '" class="kgvid_thumbnail_box kgvid_chosen_thumbnail_box kgvid_redraw_thumbnail_box" style="height:112px;"><span>' . esc_html__( 'Loading thumbnail...' ) . '</span></div>';
}

if ( empty( $security_disabled ) && current_user_can( 'make_video_thumbnails' ) ) {
Expand Down Expand Up @@ -3379,7 +3390,7 @@ function kgvid_save_thumb( $post_id, $post_name, $thumb_url, $index = false ) {
} else { // if a new thumbnail was just entered that's exactly the same as the old one, use the old one

$arr = array(
'thumb_id' => $old_thumb_id,
'thumb_id' => false,
'thumb_url' => $thumb_url,
);
return $arr;
Expand Down Expand Up @@ -3539,6 +3550,7 @@ function kgvid_video_attachment_fields_to_save( $post, $attachment ) {

if ( isset( $attachment['kgflashmediaplayer-featured'] ) ) {

$attachment['kgflashmediaplayer-featuredchanged'] = 'false';
if ( ! empty( $thumb_id ) ) {

if ( isset( $_POST['action'] )
Expand All @@ -3550,15 +3562,16 @@ function kgvid_video_attachment_fields_to_save( $post, $attachment ) {
check_ajax_referer( 'update-post_' . $id, 'nonce' );
$post_parent = kgvid_sanitize_text_field( wp_unslash( $_POST['post_id'] ) );
} elseif ( is_array( $post )
&& array_key_exists( 'post_parent', $post )
&& array_key_exists( 'post_ID', $post )
) {
$post_parent = $post['post_parent'];
$post_parent = wp_get_post_parent_id( $post['post_ID'] );
}

if ( isset( $post_parent ) ) {
if ( isset( $post_parent )
&& ! empty( $post_parent )
) {
set_post_thumbnail( $post_parent, $thumb_id );
} else {
$attachment['kgflashmediaplayer-noparent'] = true;
$attachment['kgflashmediaplayer-featuredchanged'] = 'true';
}
}
}
Expand Down Expand Up @@ -3986,14 +3999,6 @@ function kgvid_save_post( $post_id ) {
}
add_action( 'save_post', 'kgvid_save_post' );

function kgvid_attachment_updated( $post_id ) {
$featured_id = get_post_meta( $post_id, '_kgflashmediaplayer-poster-id', true );
if ( ! empty( $featured_id ) ) {
set_post_thumbnail( $post_id, $featured_id );
}
}
add_action( 'attachment_updated', 'kgvid_attachment_updated' );

function kgvid_delete_transients() {

global $wpdb;
Expand Down

0 comments on commit 6baf024

Please sign in to comment.