Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the reference of the 'CGX' CLI to the README so people can easi… #16

Merged
merged 2 commits into from Jun 13, 2019
Merged

Conversation

jeroenouw
Copy link
Contributor

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the fooBar branch (left side).
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

Please describe your pull request.

❤️ Thank you!

Copy link
Owner

@kylelobo kylelobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This project looks very useful and promising. However, I feel like it would fall under the subcategory of "Tools" in the Table of Contents.

Do you have any suggestions of how could I add it under "Tools"? Since "Tools" redirects to a Write The Docs link, the only way I can think of adding it under "Tools" is by adding it as a subpoint. However, I feel like that will disrupt the ToC structure.

@jeroenouw
Copy link
Contributor Author

@kylelobo Thank you for your response, maybe an even better idea is to place it under templates as a subpoint called template generator: cgx?

@kylelobo
Copy link
Owner

Seems reasonable. Can you make the changes?

@jeroenouw
Copy link
Contributor Author

@kylelobo I pushed the changes

@kylelobo kylelobo merged commit d18a568 into kylelobo:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants