Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile missing to install rsync (used in ovpn_copy_server_files) #73

Closed
benzht opened this issue Sep 29, 2015 · 3 comments
Closed

Comments

@benzht
Copy link

benzht commented Sep 29, 2015

The command ovpn_copy_server_files fails because rsync is not installed in the docker image.

kylemanna added a commit that referenced this issue Sep 29, 2015
* Make sure this works
* Related to #73
@kylemanna
Copy link
Owner

This should be working now.

@ypid can you make sure my changes work as expected. Also, this ovpn_copy_server_files script seems like a subset of the backup script and has issues with permissions (i.e. creates files as root), is it really necessary? Nobody has used it since rsync was never in the build.

Nevertheless, I've added a unit-test for it to prevent breakage in the future.

@ypid
Copy link
Contributor

ypid commented Sep 29, 2015

@kylemanna Thanks for keeping this project maintained 👍 including scripts which apparently only I use …
I can confirm that your changed version works as expected. About the missing rsync. I used the script myself outside of docker. Not every consistent but I saw now real benefit in doing it with docker as I wrote the script and know that it is doing and keep the CA not on the server itself.

The script is not redundant. See: https://github.com/kylemanna/docker-openvpn/blob/master/docs/paranoid.md#keep-the-ca-root-key-save

Thanks.

PS: @kylemanna Seems like there is a second user now: @benzht 😄

@kylemanna
Copy link
Owner

@ypid I'll leave it. Maintaining things is easier with travis-ci double checking the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants