Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only setup networking for containers which need it. #65

Closed
wants to merge 1 commit into from

Conversation

ypid
Copy link
Contributor

@ypid ypid commented Aug 26, 2015

And there is more paranoid stuff from me 😄

This should mitigate a hypothetical compromise of the scripts used to
manage the CA and other sensitive material.

The examples should still work and make sense although I have not tried
all of them with this change applied.

Note that I did not append the --net=none to all examples because in
some cases network is probably wanted.

This should mitigate a hypothetical compromise of the scripts used to
manage the CA and other sensitive material.

The examples should still work and make sense although I have not tried
all of them with this change applied.

Note that I did not append the --net=none to all examples because in
some cases network is probably wanted.
@kylemanna
Copy link
Owner

I'm worried that this complicates the commands people copy/paste and increase the chance of errors as it overwhelms the Docker n00bs. I think this makes most sense in the paranoid.md document as a general rule.

@ypid
Copy link
Contributor Author

ypid commented Sep 8, 2015

Well … Yes and no. What errors would you expect form this change? All the commands that I changed don’t need Internet access so why would users want to allow this?

I think using long command line arguments (as you probably always should) should be self-documenting.

@kylemanna
Copy link
Owner

It's too much noise, for what? None of the processes are even opening a socket inbound or outbound. It increases the complexity for no realistic reason.

@kylemanna kylemanna closed this Sep 8, 2015
@ypid
Copy link
Contributor Author

ypid commented Sep 8, 2015

But they could initiate a connection. Related to #68 (comment). Reason is described in my initial comment but OK I will make a second PR which only patches the paranoid.md doc.

ypid added a commit to ypid/docker-openvpn that referenced this pull request Sep 8, 2015
This should mitigate a hypothetical compromise of the scripts used to
manage the CA and other sensitive material.

The examples should still work and make sense although I have not tried
all of them with this change applied.

Note that I did not append the --net=none to all examples because in
some cases network is probably wanted.

* Changing this for all docs was not accepted by @kylemanna.
  kylemanna#65 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants