fix(WKWebview): [iOS] Add shared process pool so cookies and localSto…

…rage are shared across webviews (react-native-webview#68)
kylemantesso · Nov 15, 2018 · 19fb449 · 19fb449
1 parent b284bf9
commit 19fb449
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/ios/RNCWKWebView.h b/ios/RNCWKWebView.h
@@ -44,5 +44,7 @@ shouldStartLoadForRequest:(NSMutableDictionary<NSString *, id> *)request
 - (void)goBack;
 - (void)reload;
 - (void)stopLoading;
+
+- (instancetype)initWithProcessPool:(WKProcessPool*)processPool;
 
 @end
diff --git a/ios/RNCWKWebView.m b/ios/RNCWKWebView.m
@@ -37,6 +37,7 @@ @implementation RNCWKWebView
 {
   UIColor * _savedBackgroundColor;
   BOOL _savedHideKeyboardAccessoryView;
+  WKProcessPool *_processPool;
 }
 
 - (void)dealloc
@@ -63,6 +64,13 @@ + (BOOL)dynamicallyLoadWebKitIfAvailable
 
   return _webkitAvailable;
 }
+
+- (instancetype)initWithProcessPool:(WKProcessPool*)processPool {
+     if (self = [self initWithFrame:CGRectZero]) {
+         _processPool = processPool;
+    }
+    return self;
+}
 
 
 - (instancetype)initWithFrame:(CGRect)frame
@@ -85,6 +93,7 @@ - (void)didMoveToWindow
     };
 
     WKWebViewConfiguration *wkWebViewConfig = [WKWebViewConfiguration new];
+    wkWebViewConfig.processPool = _processPool;
     wkWebViewConfig.userContentController = [WKUserContentController new];
     [wkWebViewConfig.userContentController addScriptMessageHandler: self name: MessageHanderName];
     wkWebViewConfig.allowsInlineMediaPlayback = _allowsInlineMediaPlayback;

diff --git a/ios/RNCWKWebViewManager.m b/ios/RNCWKWebViewManager.m
@@ -18,13 +18,22 @@ @implementation RNCWKWebViewManager
 {
   NSConditionLock *_shouldStartLoadLock;
   BOOL _shouldStartLoad;
+  WKProcessPool *_processPool;
 }
 
 RCT_EXPORT_MODULE()
 
+- (id)init {
+    if (self = [super init]) {
+        _processPool = [[WKProcessPool alloc] init];
+    }
+
+    return self;
+}
+
 - (UIView *)view
 {
-  RNCWKWebView *webView = [RNCWKWebView new];
+  RNCWKWebView *webView = [[RNCWKWebView alloc] initWithProcessPool:_processPool];
   webView.delegate = self;
   return webView;
 }