Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified boxy2mne function #14

Merged
merged 2 commits into from
Apr 20, 2020
Merged

modified boxy2mne function #14

merged 2 commits into from
Apr 20, 2020

Conversation

kuziekj
Copy link
Collaborator

@kuziekj kuziekj commented Apr 20, 2020

made some changes to the boxy2mne function:

-outputs the info struct along with the channels distances
-adds the wavelengths to each channel label and to the 'locs' array (which contains the coordinates)
-converts the coordinate units in the .tol file from millimeters to meters (seems to be the units mne wants)
-also added a few more comments to explain what each section is doing

…each channel and label, and change units to meters from mm
@kuziekj kuziekj requested a review from kylemath April 20, 2020 17:31
@kylemath
Copy link
Owner

kylemath commented Apr 20, 2020

great @kuziekj , I got this feedback from the MNE developers on our plan: mne-tools/mne-python#7057 (comment)

Copy link
Owner

@kylemath kylemath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, some comments before mergin:

picks = [x for x in range(len(chan_labels))]
dists = mne.preprocessing.nirs.source_detector_distances(info, picks = picks)

return dists
return info, dists
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to change the test2.py file to collect this new output and print it as a test

###load .mtg files###

###need to have function determine sampling rate automatically, eventually
srate = 39.0625
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think we can read this from data file

@kuziekj kuziekj merged commit f2e4d71 into master Apr 20, 2020
@kylemath kylemath deleted the pyoptical_JK branch April 20, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants