Disable the Auto-pause Music menu item if the selected music player i… #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kyleneideck
added a commit
that referenced
this pull request
May 10, 2016
Disable the Auto-pause Music menu item if the selected music player isn't running
|
Merged, thanks. Sorry it took so long. By the way, I thought about it a bit more and ended up just greying out the menu item rather than disabling it completely (bbe65a2). I figure people who don't want to use auto-pause at all might want to disable it at some point, since it's enabled by default. I couldn't come up with a good way to be clearer about it in the UI, so let me know if you think it'd be better to actually disable the menu item or if you have a different suggestion. (Also, if you happen to know an easy way to grey out the check mark as well.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sn't running